Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rebuild-api test when api token is configured locally #2553

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix rebuild-api test when api token is configured locally #2553

merged 1 commit into from
Jul 15, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jul 12, 2024

When the cratesio-token is configured locally for manual testing, this test fails.

@syphar syphar requested a review from a team as a code owner July 12, 2024 17:15
@syphar
Copy link
Member Author

syphar commented Jul 12, 2024

r? @pflanze

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 12, 2024
@pflanze
Copy link
Contributor

pflanze commented Jul 12, 2024

That looks correct.

IIRC I simply assumed that the config used for tests had hardcoded defaults. TestEnvironment's base_config method creates it via Config::from_env() so that's how the env value ended up in it. I guess that might be on purpose to make it possible to run tests with different configs as part of a test suite around the test executable, thus explicitly unsetting it in my test was absolutely required.

@syphar syphar merged commit df1d37d into rust-lang:master Jul 15, 2024
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 15, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jul 17, 2024
@syphar syphar deleted the fix-rebuild-api-test branch July 17, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syphar @pflanze